Graphql with gql.tada #1776
Merged
Graphql with gql.tada #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fhenrich33
commented
Nov 24, 2024
•
fhenrich33
commented
…raphql-with-gql.tada
…raphql-with-gql.tada
…raphql-with-gql.tada
The generated schema now has different styling w.r.t. comments and
newlines but the `gql-tada generate output` command says
✓ Introspection output was generated successfully
…raphql-with-gql.tada
…raphql-with-gql.tada
…raphql-with-gql.tada
…raphql-with-gql.tada
Signed-off-by: Felipe Henrich <[email protected]>
pylipp
reviewed
Dec 4, 2024
| @@ -125,7 +125,6 @@ jobs: | |||
| command: | | |||
| pnpm lint:fix:all | |||
| pnpm format:write:all | |||
| pnpm generate-graphql-ts-types | |||
There was a problem hiding this comment.
@fhenrich33 can you add pnpm graphql-gen back in here? As a sanity-check in case the back-end files that the command depends on were renamed or similar
There was a problem hiding this comment.
@pylipp Done,
But maybe should we label the step something else since this isn't a style check?
HaGuesto
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
well done @fhenrich33. I'm already approving this PR, but you need to fix the failing build before you can merge it
|
@fhenrich33 pls add an ADR for gql.tada and playwright. FYI. @pylipp |
|
@pylipp Did I break backend tests by changing the backend's README? 😳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.