[do not merge] apply scientific-python template to enable CI/CD #1
Conversation
|
@jcfr I have been trying to see if I can get things working using the scientific-python template. Instead of editing code manually to fix all the linting errors, I want to
The latter step I am not sure how to do. I don't see any pylint or ruff configuration file where I can tell it what rules to ignore. Can you point me in the right direction? Thanks!! |
|
To exclude specific issues you could do the following. See https://github.com/ImagingDataCommons/idc-index/blob/abcc8550aeec97705249d430b862496c628a11b1/pyproject.toml#L152-L176 |
|
Instead of 477a7a3, you may want to apply these changes before the transition like it is done in ImagingDataCommons/idc-index@ca633aa |
|
It may be sensible to have one first commit only running |
|
Thanks for the advice on this! |
ebrahimebrahim
force-pushed
the
do_python_packaging_and_ci_cd
branch
from
4d2d7ef to
080b546
Compare
ebrahimebrahim
force-pushed
the
do_python_packaging_and_ci_cd
branch
from
080b546 to
29756e4
Compare
Not doing this was resulting in a mysterious pylint error: E0611: No name 'resize' in module 'skimage.transform' (no-name-in-module) Not sure why this was happening
| limitations under the License. |
There was a problem hiding this comment.
In the commit message associated with make automated style fixes using ruff, consider listing the fixes that were applied.
For example:
| @@ -123,6 +123,35 @@ ignore = [ | |||
| "PLR09", # Too many <...> | |||
| "PLR2004", # Magic value used in comparison | |||
| "ISC001", # Conflicts with formatter | |||
| "EXE002", # The file is executable but no shebang is present | |||
There was a problem hiding this comment.
| "EXE002", # The file is executable but no shebang is present | |
| # Exceptions below are specific to this project | |
| "EXE002", # The file is executable but no shebang is present |
|
Another attempt is now at #2 |
This PR is not meant to be merged but just to help explore/discuss the changes needed to apply the scientific-python template to HD_BET. If successful, the actual PR will be on the original repository and not this fork.
HD_BETtosrc/hd_betokay?