fix: make sure write events go out as soon as they can #1354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must set WANT_WRITE whenever we append to the write buffer of an ssl_client based object. This is the proper fix for the issue patched by @Neko-Life where voice wasn't sending via socketengine events. If the opcode 4 was not sent soon enough, then the connection would not succeed, this seems oddly temporal now. Setting WANT_WRITE in the ssl_client::write() function ensures all writes occur as soon as they possibly can.
Code change checklist