Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure write events go out as soon as they can #1354

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

braindigitalis
Copy link
Contributor

We must set WANT_WRITE whenever we append to the write buffer of an ssl_client based object. This is the proper fix for the issue patched by @Neko-Life where voice wasn't sending via socketengine events. If the opcode 4 was not sent soon enough, then the connection would not succeed, this seems oddly temporal now. Setting WANT_WRITE in the ssl_client::write() function ensures all writes occur as soon as they possibly can.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 25290d1
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/67649cf56054400008d8deef
😎 Deploy Preview https://deploy-preview-1354--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis added the audio audio issues or feature requests label Dec 19, 2024
@github-actions github-actions bot added the code Improvements or additions to code. label Dec 19, 2024
Copy link
Member

@Neko-Life Neko-Life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう!!!

@braindigitalis braindigitalis merged commit 45a233a into dev Dec 22, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio audio issues or feature requests code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants