Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Coro is now default enabled. #1368

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

feat: Coro is now default enabled. #1368

wants to merge 10 commits into from

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Jan 31, 2025 •
edited
Loading

This PR turns Coro On by default, swapping all #ifdef DPP_CORO to be #ifndef DPP_NO_CORO, and making the CMakeLists.txt turn DPP_NO_CORO on if coroutines aren't supported.

Also changed the .gitignore to ignore any folder starting with cmake-build- so it auto excludes folders made for specific compilers too (like cmake-build-debug-vs)

Closes #1347

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Jaskowicz1 Jaskowicz1 self-assigned this Jan 31, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 31, 2025 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit a46d234
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/679cfaed5280ba0008585e5f
😎 Deploy Preview https://deploy-preview-1368--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation build Issue or Pull Request related to the build process code Improvements or additions to code. labels Jan 31, 2025
@Jaskowicz1 Jaskowicz1 requested review from Mishura4 and braindigitalis and removed request for Mishura4 January 31, 2025 10:57
@Jaskowicz1 Jaskowicz1 linked an issue Jan 31, 2025 that may be closed by this pull request
Coroutines in 10.1 should default to ON if you are on C++20 with a supporting compiler #1347
Open
@braindigitalis
Copy link
Contributor

need CI to be fixed first, then can be merged

@braindigitalis braindigitalis added this to the 10.1 milestone Jan 31, 2025
@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review January 31, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

@Mishura4 Mishura4 Awaiting requested review from Mishura4

Assignees

@Jaskowicz1 Jaskowicz1

Labels
build Issue or Pull Request related to the build process code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
D++ 10.1.0 release
Status: No status
Milestone
10.1
Development

Successfully merging this pull request may close these issues.

Coroutines in 10.1 should default to ON if you are on C++20 with a supporting compiler
2 participants
@Jaskowicz1 @braindigitalis