Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new cache example and file name fixes #862

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

professor91
Copy link
Contributor

  • Added example for using cache

  • Replaced - with _ in filenames and updated in respective md files

  • Moved permissions example md file of Misc category to /misc dir

  • My pull request is made against the dev branch.

  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.

  • I have ensured that all methods and functions are fully documented using doxygen style comments.

  • I tested my commits, by adding a test case to the unit tests if needed

  • I have ensured that I did not break any existing API calls.

  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).

  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit d56f74a
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/650a6fe4a288990008e87673
😎 Deploy Preview https://deploy-preview-862--dpp-dev.netlify.app/using-cache
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure there's any need to rename all the images apart from that looks good 👍

@professor91
Copy link
Contributor Author

updated

Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also revert the name changes of the markdown files?
they don't need to be changed

@professor91
Copy link
Contributor Author

can you please also revert the name changes of the markdown files? they don't need to be changed

i changed so they'd in consistent format...the links don't change if that's your concern, lmk if they still need to be revert back

@braindigitalis
Copy link
Contributor

can you please also revert the name changes of the markdown files? they don't need to be changed

i changed so they'd in consistent format...the links don't change if that's your concern, lmk if they still need to be revert back

yeah please revert those as it makes the PR shorter

@professor91
Copy link
Contributor Author

added new line and reverted markdown filenames

@braindigitalis braindigitalis merged commit 8ffbe74 into brainboxdotcc:dev Sep 20, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants