-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new cache example and file name fixes #862
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure there's any need to rename all the images apart from that looks good 👍
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please also revert the name changes of the markdown files?
they don't need to be changed
i changed so they'd in consistent format...the links don't change if that's your concern, lmk if they still need to be revert back |
yeah please revert those as it makes the PR shorter |
added new line and reverted markdown filenames |
Added example for using cache
Replaced - with _ in filenames and updated in respective md files
Moved permissions example md file of Misc category to /misc dir
My pull request is made against the
dev
branch.I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
I have ensured that all methods and functions are fully documented using doxygen style comments.
I tested my commits, by adding a test case to the unit tests if needed
I have ensured that I did not break any existing API calls.
My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.