-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remade the linux.md page. #875
Conversation
Co-authored-by: Jakub 'Eremiell' Marek <[email protected]>
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure we should be merging the pages together... it means duplicated content on Google which is bad and means two places to maintain.
simply link to the cmake guide at the bottom as we did before?
They're not the same. The CMake guide no longer uses source, the new addition here shows CMake with source. Ideally, I'd like two separate pages, unless you can come up with a better idea! |
problem is this a guide on how to build the lib and now it's also a guide on how to build a bot... the lines are blurred and it isn't so clear any more. perhaps a separate new page for it that this one links to? |
Yeah that's actually a good point, I didn't really think of that. So, if we're to make a separate page for building a bot using source with CMake, where would we place that? I don't think placing it next to the |
bury it at the bottom of this one with a hyperlink to it so that you have to be looking for it to find it, this encourages people by default to install how we can support them easier, same way we funnel them towards the windows template. |
I like that idea haha. However, if it's not listed as a "subpage" anywhere, it'll become a top page (like FAQ) so it needs to be under some sub-section. I think we should also have a discussion about the linux template, if you're available for that :) |
This PR remakes the
linux.md
page, basically taking the old buildcmake.md page and adding it here (but, ofc, improved), meaning the page now covers g++ and CMake. This PR also merges the changes onlinux.md
from #820.Documentation change checklist
oxygen
, and testing examples).