Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added OpenBSD to readme #891

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Conversation

transgirllucy
Copy link
Contributor

related to this PR #880

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit e07d76f
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65114eb68322ff0007d59144
😎 Deploy Preview https://deploy-preview-891--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1
Copy link
Contributor

Jaskowicz1 commented Sep 25, 2023

You'll need to change the name of this PR to be something like refactor: added OpenBSD to readme to follow the naming convention for PRs!

Other than this, I'm not entirely sure this is stable on OpenBSD either and would require more testing. I do know that clang and g++ on OpenBSD refuse to see libdpp.so.10.0.26 in /usr/local/lib so I don't know if we want to say it's "stable" when you can't use it after make install.

@braindigitalis braindigitalis changed the title added OpenBSD docs: added OpenBSD to readme Sep 25, 2023
@braindigitalis
Copy link
Contributor

@mrtuxa are the many issues with openbsd that @Jaskowicz1 is having an "us problem", or is there a fix? Do they need to be part of this change if we are claiming its fully supported?

@transgirllucy
Copy link
Contributor Author

@mrtuxa are the many issues with openbsd that @Jaskowicz1 is having an "us problem", or is there a fix? Do they need to be part of this change if we are claiming its fully supported?

i will do some tests the next days

@Jaskowicz1
Copy link
Contributor

@mrtuxa are the many issues with openbsd that @Jaskowicz1 is having an "us problem", or is there a fix? Do they need to be part of this change if we are claiming its fully supported?

i will do some tests the next days

Thank you :)

@transgirllucy
Copy link
Contributor Author

@mrtuxa are the many issues with openbsd that @Jaskowicz1 is having an "us problem", or is there a fix? Do they need to be part of this change if we are claiming its fully supported?

i will do some tests the next days

Thank you :)

But the problem is i'm not very familiar with OpenBSD but I try my best

@Jaskowicz1
Copy link
Contributor

@mrtuxa are the many issues with openbsd that @Jaskowicz1 is having an "us problem", or is there a fix? Do they need to be part of this change if we are claiming its fully supported?

i will do some tests the next days

Thank you :)

But the problem is i'm not very familiar with OpenBSD but I try my best

Don't worry! If you manage to get it working, tell us what you did and I'll see if I can get it working too.

Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #901 , I'm happy to say this PR is okay! DPP is functional and stable on OpenBSD, the issues that occur on OpenBSD are not related to DPP so people just need to use CMake (which we highly encourage for other platforms anyways).

@Jaskowicz1 Jaskowicz1 added the documentation Improvements or additions to documentation label Oct 1, 2023
@Jaskowicz1 Jaskowicz1 merged commit a49d867 into brainboxdotcc:dev Oct 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants