Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should fix #714, closes out issue where length of websocket-sec-key was wrong #900

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Sep 29, 2023

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Sep 29, 2023
@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 708011a
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65169daa2dc60a000886e587
😎 Deploy Preview https://deploy-preview-900--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis added bug Something isn't working audio audio issues or feature requests build Issue or Pull Request related to the build process labels Sep 29, 2023
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look alright, will do tests to see if it works.

Copy link
Member

@Neko-Life Neko-Life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/dpp/wsclient.cpp Show resolved Hide resolved
@braindigitalis braindigitalis merged commit 7cc57af into dev Sep 29, 2023
50 checks passed
@Jaskowicz1
Copy link
Contributor

Jaskowicz1 commented Sep 29, 2023

Discord API keeps going down, meaning a test can't be properly conducted. I've done as much as was possible. It seems the fix is working well.

Region          | Server            | Response
---------------------------------------------------------------------
Brazil          | brazil7074        | 101 Switching Protocols (271ms)
Hong Kong       | hongkong11003     | 101 Switching Protocols (255ms)
India           | india1813         | 101 Switching Protocols (171ms)
Japan           | japan80           | 101 Switching Protocols (302ms)
Rotterdam       | rotterdam1572     | 101 Switching Protocols (58ms)
Russia          | N/A               | Discord API failed.
Singapore       | N/A               | Discord API failed.
South Africa    | N/A               | Discord API failed.
Syndey          | N/A               | Discord API failed.
US Central      | N/A               | Discord API failed.
US East         | N/A               | Discord API failed.
US South        | N/A               | Discord API failed.
US West         | N/A               | Discord API failed.

@Jaskowicz1 Jaskowicz1 deleted the further_ws_fixes branch April 4, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio audio issues or feature requests bug Something isn't working build Issue or Pull Request related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot is unable to properly connect to certain Discord voice servers
4 participants