Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guild member flags can't be set by a bot #911

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 2, 2023

Guild member flags cannot be set by a bot. They are set by a user in the client. Sending them causes permission denied. The deaf/muted settings are separate and sent as individual bools in the json, and can be set by a bot.

In fact, the flags that this would set, we don't even have set_ methods for.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis added the bug Something isn't working label Oct 2, 2023
@braindigitalis braindigitalis self-assigned this Oct 2, 2023
@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit d2c7a42
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/651b382d964e790008cce05e
😎 Deploy Preview https://deploy-preview-911--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis merged commit 1d9e94e into dev Oct 2, 2023
@braindigitalis braindigitalis deleted the dont_send_flags_in_guild_member_edit branch October 2, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants