refactor: added json to dpp.h includes #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
documentation
Mishura4
reviewed
Oct 5, 2023
braindigitalis
requested changes
Oct 5, 2023
| @@ -73,3 +73,5 @@ | |||
| #include <dpp/discordevents.h> | |||
| #include <dpp/timed_listener.h> | |||
| #include <dpp/collector.h> | |||
| #include <dpp/json_fwd.h> | |||
| #include <dpp/json.h> | |||
There was a problem hiding this comment.
we can't do this as it won't work for packages that have USE_EXTERNAL_JSON defined plus leaving this out is intentional as it slows down the build massively.
There was a problem hiding this comment.
I thought that was handled by dpp/json.h though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds json_fwd.h and json.h into the dpp.h includes, this means we aren't relying on other headers to include json as, if they have json removed, json will no longer be implemented by default.
Code change checklist