Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for hsl colors #924

Merged
merged 7 commits into from
Oct 5, 2023

Conversation

ruslan-ilesik
Copy link
Contributor

feat: added support for hsl colors to be used in embed

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit c34ad3b
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/651f18d6fc4aa000081f0d06
😎 Deploy Preview https://deploy-preview-924--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 5, 2023
@Jaskowicz1 Jaskowicz1 added the enhancement New feature or request label Oct 5, 2023
include/dpp/utility.h Outdated Show resolved Hide resolved
include/dpp/utility.h Outdated Show resolved Hide resolved
Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nicer now. as a future change id like to make the 1/3 etc constexpr values (in a new pr)
it is likely that all our RGB, HSL etc functions could be constexpr in the future as they're mainly used to define constant colours.

include/dpp/utility.h Outdated Show resolved Hide resolved
src/dpp/utility.cpp Outdated Show resolved Hide resolved
src/dpp/utility.cpp Outdated Show resolved Hide resolved
src/dpp/utility.cpp Outdated Show resolved Hide resolved
src/dpp/utility.cpp Outdated Show resolved Hide resolved
src/dpp/utility.cpp Outdated Show resolved Hide resolved
@braindigitalis braindigitalis merged commit 8851eab into brainboxdotcc:dev Oct 5, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants