Translating Error Messages #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this call to `trans` the custom error messages are not translated, only the proper built-in ones.
|
Hm.. Before your patch the code is same as in template provided by symfony. I guess that the problem lies somewhere else.? |
|
@mvrhov You're right. We had the call to I guess the problem is with the translation domains. When there is no translation domain given (like in this PR) custom error messages are not translated. On the other side when adding the translation domain the default error messages are not translated. |
|
Shouldn't the translation domain default to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this call to
transthe custom error messages are not translated, only the proper built-in ones.