-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downsampling script for tadpoles #26
Conversation
a98a4df
to
c38292d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go as is, but I'm slightly confused as to why certain arguments are hard-coded in the functions (e.g. in_plane_resolution
), while others are supplied as CLI arguments (e.g. target_isotropic resolution
).
Is the logic that some factors - like in-plane resolution - are intrinsic to the source images themselves, and hence unchanging, while the arguments supplied through the CLI can be used to run the downsampling in different ways (e.g. send results to a different path, or change the downsampling factor)?
This discussion is largely moot, since we are planning to anyway refactor and possible used a config, but I'm just curious.
I was being a minimalist, and for our current purpose we needed to downsample to different target isotropic resolutions, but all our images had the same (anisotropic) resolution? |
for more information, see https://pre-commit.ci
Description
What is this PR
Why is this PR needed?
Keep track of how we downsampled the tadpole data.
What does this PR do?
Add script for tadpole downsampling and organising (to go from "sourcedata" to "rawdata")
References
\
How has this PR been tested?
Visual inspection of tadpole data. Downsampling functionality added with tests in #21
Is this a breaking change?
No
Does this PR require an update to the documentation?
Not yet
Checklist: