Merge pull request #352 from brainglobe/fix-outlines

Fix jagged renderings in cartoon mode and restore default shader style

brainrender/render.py

@@ -192,7 +192,6 @@ def render(
         interactive=None,
         camera=None,
         zoom=None,
-        update_camera=True,
         **kwargs,
     ):
         """
@@ -205,7 +204,6 @@ def render(
             Pass a valid camera input to specify the camera position when
             the scene is rendered.
         :param zoom: float, if None atlas default is used
-        :param update_camera: bool, if False the camera is not changed
         :param kwargs: additional arguments to pass to self.plotter.show
         """
         logger.debug(
@@ -229,7 +227,7 @@ def render(
             camera["focal_point"] = self.root._mesh.center_of_mass()
 
         if not self.backend and camera is not None:
-            camera = set_camera(self, camera)
+            _ = set_camera(self, camera)
 
         # Apply axes correction
         for actor in self.clean_actors:
@@ -266,7 +264,6 @@ def render(
                 interactive=interactive,
                 zoom=zoom,
                 bg=settings.BACKGROUND_COLOR,
-                camera=camera.copy() if update_camera else None,
                 rate=40,
                 axes=self.plotter.axes,
             )

brainrender/settings.py

@@ -32,7 +32,7 @@
 ROOT_COLOR = [0.8, 0.8, 0.8]  # color of the overall brain model's actor
 ROOT_ALPHA = 0.2  # transparency of the overall brain model's actor'
 SCREENSHOT_SCALE = 1
-SHADER_STYLE = "plastic"  # affects the look of rendered brain regions: [metallic, plastic, shiny, glossy, cartoon]
+SHADER_STYLE = "cartoon"  # affects the look of rendered brain regions: [metallic, plastic, shiny, glossy, cartoon]
 SHOW_AXES = True
 WHOLE_SCREEN = False  # If true render window is full screen
 OFFSCREEN = False