Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CreateJsonResource from testcase to custom trait #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move CreateJsonResource from testcase to custom trait #7

wants to merge 2 commits into from

Conversation

brdv
Copy link
Member

@brdv brdv commented Apr 13, 2023

No description provided.

@brdv brdv requested review from Fafabian and fa-fabian April 13, 2023 07:56
Fafabian
Fafabian reviewed Apr 17, 2023
View reviewed changes
tests/TestCase.php

class TestCase extends \Orchestra\Testbench\TestCase
{
use JsonResourceHelper;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use JsonResourceHelper;
use JsonResourceHelper;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fafabian Fafabian Fafabian left review comments

@fa-fabian fa-fabian Awaiting requested review from fa-fabian

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brdv @Fafabian