Add UnitTests for PayPalNativeCheckout Module
#1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd BTPayPalNativeCheckoutStartable for testing MXO; update implimentation
# Conflicts: # Sources/BraintreePayPalNativeCheckout/BTPayPalNativeCheckoutClient.swift
sarahkoop
reviewed
Dec 5, 2023
UnitTests/BraintreePayPalNativeCheckoutTests/BTPayPalNativeCheckoutProvider_Tests.swift
Outdated
Show resolved
Hide resolved
scannillo
reviewed
Dec 6, 2023
UnitTests/BraintreePayPalNativeCheckoutTests/BTPayPalNativeCheckoutClient_Tests.swift
Outdated
Show resolved
Hide resolved
scannillo
reviewed
Dec 6, 2023
UnitTests/BraintreePayPalNativeCheckoutTests/BTPayPalNativeCheckoutClient_Tests.swift
Outdated
Show resolved
Hide resolved
…ckoutClient_Tests.swift Co-authored-by: scannillo <[email protected]>
scannillo
reviewed
Dec 6, 2023
Comment on lines
148
to
151
| XCTAssertEqual(error.domain, BTPayPalNativeCheckoutError.errorDomain) | ||
| XCTAssertEqual(error.code, BTPayPalNativeCheckoutError.orderCreationFailed(BTPayPalNativeCheckoutError.invalidJSONResponse).errorCode) | ||
| XCTAssertEqual(error.localizedDescription, BTPayPalNativeCheckoutError.orderCreationFailed(BTPayPalNativeCheckoutError.invalidJSONResponse).errorDescription) | ||
| expectation.fulfill() |
There was a problem hiding this comment.
Nitpick - I think ideally the tests should assert on the raw string values & raw int codes expected, versus referring to constants in the SDK. Otherwise we don't catch spelling errors or typos.
There was a problem hiding this comment.
Done: 2325569
Do we think it's worth documenting this somewhere? Not sure if the style guide or elsewhere is best.
scannillo
approved these changes
Dec 6, 2023
sarahkoop
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
BTPayPalNativeCheckoutStartable(PPCP version)BTPayPalNativeCheckoutProvider(PPCP version)BTPayPalNativeCheckoutProtocol(PPCP version)BTPayPalNativeCheckoutProvider_Testsand add additional unit tests toBTPayPalNativeCheckoutClient_Tests- many of the added tests are 1:1 with the tests for this module on PPCPChecklist
[ ] Added a changelog entryAuthors