Paypal Messaging Analytics #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: scannillo <[email protected]>
jaxdesmarais
commented
Dec 14, 2023
jaxdesmarais
commented
Dec 14, 2023
| @@ -141,10 +142,12 @@ extension BTPayPalMessagingClient: PayPalMessageViewEventDelegate, PayPalMessage | |||
| } | |||
|
|
|||
| public func onSuccess(_ paypalMessageView: PayPalMessages.PayPalMessageView) { | |||
| apiClient.sendAnalyticsEvent(BTPayPalMessagingAnalytics.succeeded) | |||
There was a problem hiding this comment.
Typically we have used the notify pattern in other PRs. Open to using that pattern here if folks prefer but to me it seemed odd to extract out the delegate call below and the analytics event for just success and error while keeping the rest of the delegate calls above when we aren't sending analytics.
jaxdesmarais
commented
Dec 14, 2023
sarahkoop
approved these changes
Dec 14, 2023
…tree/braintree_ios into paypal-messaging-analytics
1 task
hollabaq86
reviewed
Dec 14, 2023
There is a follow up ticket as a whole for testing this feature. Since this is going into a feature branch we wanted to keep the PRs small/digestible. But there will be tests - that will be the next PR once the current 3 are merged in. 😄 |
scannillo
approved these changes
Dec 15, 2023
|
@jaxdesmarais ahhhh I see. Carry on! |
sshropshire
approved these changes
Dec 18, 2023
Base automatically changed from
paypal-messaging-demo-app
to
paypal-messaging-feature
December 20, 2023 14:16
# Conflicts: # Braintree.xcodeproj/project.pbxproj # CHANGELOG.md # Demo/Application/Features/PayPalMessagingViewController.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingDelegate.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingError.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingLogoType.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingRequest.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingView.swift
# Conflicts: # Braintree.xcodeproj/project.pbxproj # CHANGELOG.md # Demo/Application/Features/PayPalMessagingViewController.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingDelegate.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingError.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingLogoType.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingRequest.swift # Sources/BraintreePayPalMessaging/BTPayPalMessagingView.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is going into the
paypal-messaging-featurebranchSummary of changes
started,failed, andsucceededevents for PayPal Messaging featureChecklist
[ ] Added a changelog entryAuthors