Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v5] Expose isDeviceToken on BTApplePayCardNonce #1522

Merged
merged 5 commits into from
Feb 21, 2025
Merged

[v5] Expose isDeviceToken on BTApplePayCardNonce #1522

merged 5 commits into from
Feb 21, 2025

Conversation

stechiu
Copy link
Collaborator

@stechiu stechiu commented Feb 14, 2025

With this PR, Merchants will have the ability to see if their ApplePay payment was tokenized as an MPAN or DPAN.

Summary of changes

  • Exposed isDeviceToken
  • false == DPAN
  • true == MPAN

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@stechiu stechiu requested a review from a team as a code owner February 14, 2025 01:22
@stechiu stechiu changed the base branch from main to v5-mpan-feature February 14, 2025 01:24
scannillo
scannillo approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@scannillo scannillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏Nice!

warmkesselj
warmkesselj reviewed Feb 14, 2025
View reviewed changes
Sources/BraintreeApplePay/Public/BraintreeApplePay/BTApplePayCardNonce.h Outdated
@@ -16,6 +16,11 @@ NS_ASSUME_NONNULL_BEGIN
*/
@property (nonatomic, readonly, strong) BTBinData *binData;

/**
This Boolean (available on iOS 16+) indicates whether this tokenized card is a device-specific account number (DPAN) or merchant/cloud token (MPAN). If `isDeviceToken` is `false`, then token type is MPAN.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space 16+) in

@jaxdesmarais
Copy link
Contributor

I put up PR #1525 to fix the tests no-oping if we want to merge that in first.

agedd
agedd approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! 🚀

@stechiu stechiu mentioned this pull request Feb 19, 2025
Merged
2 tasks
@stechiu stechiu merged commit bcadef5 into v5-mpan-feature Feb 21, 2025
5 of 6 checks passed
@stechiu stechiu deleted the v5-mpan-expose-isDeviceToken branch February 21, 2025 01:02
stechiu added a commit that referenced this pull request Feb 24, 2025
@stechiu
[v5] Merge Apple MPAN into 5.x branch (#1528)
7c63073 
* [v5] Expose isDeviceToken on BTApplePayCardNonce (#1522)

* V5 mpan demo app (#1526)

* Exposed isDeviceToken. Added unit tests

* Update BTApplePayCardNonce.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmkesselj warmkesselj warmkesselj left review comments

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@scannillo scannillo scannillo approved these changes

@agedd agedd agedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stechiu @jaxdesmarais @scannillo @agedd @warmkesselj