Configure typescript build and lint #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
approved these changes
Jul 4, 2024
src/declarations.d.ts
Outdated
Comment on lines
17
to
18
| type UnboundOperatorFunc = (OperatorArg, HTMLElement) => OperatorResult | ||
| type OperatorFunc = (HTMLElement) => OperatorResult |
There was a problem hiding this comment.
ERROR in brave-browser/src/brave/components/cosmetic_filters/resources/data/content_cosmetic.ts
./components/cosmetic_filters/resources/data/content_cosmetic.ts 806:30-41
[tsl] ERROR in brave-browser/src/brave/components/cosmetic_filters/resources/data/content_cosmetic.ts(806,31)
TS7051: Parameter has a name but no type. Did you mean 'arg0: OperatorArg'?
ERROR in brave-browser/src/brave/components/cosmetic_filters/resources/data/content_cosmetic.ts
./components/cosmetic_filters/resources/data/content_cosmetic.ts 806:43-54
[tsl] ERROR in brave-browser/src/brave/components/cosmetic_filters/resources/data/content_cosmetic.ts(806,44)
TS7051: Parameter has a name but no type. Did you mean 'arg1: HTMLElement'?
ERROR in brave-browser/src/brave/components/cosmetic_filters/resources/data/content_cosmetic.ts
./components/cosmetic_filters/resources/data/content_cosmetic.ts 807:23-34
[tsl] ERROR in brave-browser/src/brave/components/cosmetic_filters/resources/data/content_cosmetic.ts(807,24)
TS7051: Parameter has a name but no type. Did you mean 'arg0: HTMLElement'?
There was a problem hiding this comment.
Suggested change
| type UnboundOperatorFunc = (OperatorArg, HTMLElement) => OperatorResult | |
| type OperatorFunc = (HTMLElement) => OperatorResult | |
| type UnboundOperatorFunc = (arg: OperatorArg, element: HTMLElement) => OperatorResult | |
| type OperatorFunc = (element: HTMLElement) => OperatorResult |
| type Filter = Operator[] | ||
|
|
||
| type NeedlePosition = number | ||
| type TextMatchRule = (targetText: string, exact: boolean = false) => boolean |
There was a problem hiding this comment.
ERROR in brave-browser/src/brave/components/cosmetic_filters/resources/data/content_cosmetic.ts
./components/cosmetic_filters/resources/data/content_cosmetic.ts 819:44-66
[tsl] ERROR in brave-browser/src/brave/components/cosmetic_filters/resources/data/content_cosmetic.ts(819,45)
TS2371: A parameter initializer is only allowed in a function or constructor implementation.
There was a problem hiding this comment.
Suggested change
| type TextMatchRule = (targetText: string, exact: boolean = false) => boolean | |
| type TextMatchRule = (targetText: string, exact?: boolean) => boolean |
pes10k
force-pushed
the
improved-typescript
branch
from
0a3cd30 to
baf9aaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also handled Antons
:case for CSS rules, and quoted CSS values