Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove call to check reputation during wallet linking #2069

Merged
merged 2 commits into from
Oct 11, 2023
Merged

remove call to check reputation during wallet linking #2069

merged 2 commits into from
Oct 11, 2023

Conversation

evq
Copy link
Contributor

@evq evq commented Oct 5, 2023 •
edited by clD11
Loading

Summary

removes the call to check reputation during wallet linking

fixes #171

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

@Miyayes Miyayes requested review from husobee and clD11 October 5, 2023 20:19
@clD11 clD11 force-pushed the remove-linking-rep-call branch from 176a536 to 89bb215 Compare October 11, 2023 10:29
@clD11 clD11 merged commit f1282f3 into master Oct 11, 2023
9 checks passed
@clD11 clD11 deleted the remove-linking-rep-call branch October 11, 2023 10:50
@Miyayes
Copy link
Collaborator

Miyayes commented Oct 11, 2023

Resolves: https://github.com/brave-intl/payment-services/issues/171

evq added a commit that referenced this pull request Oct 16, 2023
@evq
Revert "remove call to check reputation during wallet linking (#2069)"
70e5f41 
This reverts commit f1282f3.
@evq evq mentioned this pull request Oct 16, 2023
Merged
clD11 pushed a commit that referenced this pull request Oct 16, 2023
@evq
Revert "remove call to check reputation during wallet linking (#2069)" (
c0dd131 
#2147)

This reverts commit f1282f3.
@hspencer77 hspencer77 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clD11 clD11 clD11 approved these changes

@husobee husobee Awaiting requested review from husobee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evq @Miyayes @clD11