Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow flagged users to link #2148

Merged
merged 1 commit into from
Oct 16, 2023
Merged

feat: allow flagged users to link #2148

merged 1 commit into from
Oct 16, 2023

Conversation

clD11
Copy link
Contributor

@clD11 clD11 commented Oct 16, 2023 •
edited
Loading

Summary

Allow flagged users to link

We need to maintain the reputation linking call to reputation as it performs a series of actions. In the future we should remove the call and unify the reputation calls and linking flow. This can be addressed in the wallet refactor ticket #163

This PR will resolves #171

  • Remove logic to stop flagged users linking
  • Remove unnecessary logging
  • Cleanup link wallet method

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@clD11 clD11 requested a review from pavelbrm October 16, 2023 20:36
@clD11 clD11 self-assigned this Oct 16, 2023
husobee
husobee approved these changes Oct 16, 2023
View reviewed changes
services/wallet/datastore.go Show resolved Hide resolved
@clD11
feat: allow flagged users to link
83c0d06 
* remove logic to stop flagged users linking
* remove unnecessary logging
* cleanup link wallet method
@clD11 clD11 force-pushed the allow-flagged-users-to-link branch from d85d726 to 83c0d06 Compare October 16, 2023 21:03
@clD11 clD11 merged commit 48d76c5 into master Oct 16, 2023
@clD11 clD11 deleted the allow-flagged-users-to-link branch October 16, 2023 21:33
@clD11 clD11 removed the request for review from pavelbrm October 16, 2023 21:41
pavelbrm
pavelbrm reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am late, but still have had a look. 🙂

services/wallet/datastore.go Show resolved Hide resolved
services/wallet/datastore.go Show resolved Hide resolved
@clD11 clD11 mentioned this pull request Oct 17, 2023
Merged
@hspencer77 hspencer77 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelbrm pavelbrm pavelbrm left review comments

@husobee husobee husobee approved these changes

Assignees

@clD11 clD11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clD11 @pavelbrm @husobee