Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate blinded tokens submitted for tlv2 #2158

Merged
merged 6 commits into from
Oct 20, 2023
Merged

validate blinded tokens submitted for tlv2 #2158

merged 6 commits into from
Oct 20, 2023

Conversation

husobee
Copy link
Contributor

@husobee husobee commented Oct 18, 2023

Summary

validation of tlv2 time limited v2 blinded tokens submitted, fixes: #2157

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@husobee husobee self-assigned this Oct 18, 2023
pavelbrm
pavelbrm suggested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments and requesting changes, because, as it stands, the PR will fail to accomplish what it is intending to.

services/skus/credentials.go Outdated Show resolved Hide resolved
services/skus/credentials.go Outdated Show resolved Hide resolved
services/skus/credentials.go Outdated Show resolved Hide resolved
services/skus/credentials.go Outdated Show resolved Hide resolved
services/skus/credentials.go Outdated Show resolved Hide resolved
services/skus/credentials.go Outdated Show resolved Hide resolved
@husobee husobee requested a review from pavelbrm October 19, 2023 16:16
@pavelbrm pavelbrm mentioned this pull request Oct 20, 2023
Merged
pavelbrm
pavelbrm previously requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @husobee. I provided further feedback in #2160.

@pavelbrm
Patches For 2158 (#2160)
5381643 
* Refactor code and tests

* Remove unnecessary type conversion

* Use better names
@husobee husobee requested a review from pavelbrm October 20, 2023 12:59
@husobee husobee dismissed pavelbrm’s stale review October 20, 2023 14:54

accepted patch pr with reviewers suggestions

@husobee husobee merged commit cc9860c into master Oct 20, 2023
9 checks passed
@husobee husobee deleted the validate-numPerInterval branch October 20, 2023 14:55
@hspencer77 hspencer77 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evq evq evq approved these changes

@pavelbrm pavelbrm Awaiting requested review from pavelbrm

Assignees

@husobee husobee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate correct order item blinded tokens for skus create order item credentials tlv2
3 participants
@husobee @pavelbrm @evq