Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: disable tos #2684

Merged
merged 3 commits into from
Oct 29, 2024
Merged

refactor: disable tos #2684

merged 3 commits into from
Oct 29, 2024

Conversation

clD11
Copy link
Contributor

@clD11 clD11 commented Oct 28, 2024 •
edited
Loading

Summary

This PR disables/removes the TOS from the GET /parameters response until it is required.

N.B. This is not live in production at this time.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@clD11 clD11 self-assigned this Oct 28, 2024
@clD11 clD11 requested a review from pavelbrm October 28, 2024 11:51
pavelbrm
pavelbrm reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test looks like it needs to be updated as well – https://github.com/brave-intl/bat-go/blob/master/services/rewards/controllers_test.go#L117.

@clD11 clD11 merged commit fc1675d into master Oct 29, 2024
12 checks passed
@clD11 clD11 deleted the disable-tos branch October 29, 2024 18:22
@clD11 clD11 mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelbrm pavelbrm pavelbrm approved these changes

Assignees

@clD11 clD11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clD11 @pavelbrm