-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use customer id when present whilst creating a premium order #2715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - reviewed this as a part of https://github.com/brave/reviews/issues/1822
As long as I'm understanding the flow of this properly, I think we are introducing a correlating tracker here that we don't want. I need to keep reviewing to be sure, but definitely want to call it out early so we can revert this here and find a different approach to this if it is the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these tests in here - it made it much simpler to understand what this change was doing.
I don't think so. This has always been here in a slightly different form. This data is not kept in SKUs. SKUs used to figure out the customer id itself in some flows, but now it accepts it. |
Summary
This PR makes it possible for the known customer to be passed when creating a premium order. Additionally, this makes use of the customer information obtained from the old session when recreating one (mainly as part of the set trial days call).
Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan