Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: renew uphold cert #2716

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: renew uphold cert #2716

merged 1 commit into from
Nov 20, 2024

Conversation

clD11
Copy link
Contributor

@clD11 clD11 commented Nov 20, 2024

Summary

Renew Uphold intermediate cert

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@clD11 clD11 self-assigned this Nov 20, 2024
@clD11 clD11 requested a review from Sneagan November 20, 2024 17:18
@clD11 clD11 merged commit 38efbd6 into master Nov 20, 2024
13 checks passed
@clD11 clD11 deleted the update-cert-1 branch November 20, 2024 17:25
@clD11 clD11 mentioned this pull request Nov 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 20, 2024
@clD11
Merge pull request #2717 from brave-intl/master
35b5916 
fix: renew uphold cert (#2716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sneagan Sneagan Sneagan approved these changes

Assignees

@clD11 clD11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clD11 @Sneagan