Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't panic when issuer wasn't found for vote #2720

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

pavelbrm
Copy link
Contributor

@pavelbrm pavelbrm commented Nov 28, 2024

Summary

This PR fixes a panic when the issuer wasn't found whilst voting.

There has been a spike in panics due to not found issuer because the datastore method returns nil, nil when not found, and the caller does not check the result for nil-ness.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@pavelbrm pavelbrm marked this pull request as ready for review November 28, 2024 06:28
@pavelbrm pavelbrm self-assigned this Nov 28, 2024
@pavelbrm pavelbrm requested a review from clD11 November 28, 2024 06:28
@pavelbrm pavelbrm merged commit 28be327 into master Nov 28, 2024
13 checks passed
@pavelbrm pavelbrm deleted the fix-vote-panic branch November 28, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants