Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove payment and nitro code #2730

Merged
merged 9 commits into from
Dec 17, 2024
Merged

feat: remove payment and nitro code #2730

merged 9 commits into from
Dec 17, 2024

Conversation

clD11
Copy link
Contributor

@clD11 clD11 commented Dec 13, 2024

Summary

The payments service has been migrated to a separate repository so we no longer need the code in bat-go.

resolves #2708

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@clD11 clD11 changed the title Remove payment and nitro feat: remove payment and nitro code Dec 13, 2024
@clD11 clD11 marked this pull request as ready for review December 13, 2024 12:37
@clD11 clD11 requested review from Sneagan, DJAndries, kdenhartog and pavelbrm and removed request for kdenhartog December 13, 2024 12:37
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kdenhartog
Copy link
Member

Do we still need tools/settlement too?

@clD11
Copy link
Contributor Author

clD11 commented Dec 16, 2024

Do we still need tools/settlement too?

@kdenhartog , Yes, until all the custodians and creators are moved over to payments it is still needed.

Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clD11 clD11 enabled auto-merge (squash) December 17, 2024 06:45
Copy link

[puLL-Merge] - brave-intl/bat-go@2730

Description

This PR removes significant portions of code related to Nitro enclave functionality, including AWS QLDB integration, state machine implementations for different custodians (Bitflyer, Gemini, Uphold), and various payment-related tools and configurations.

Possible Issues

  1. Removal of functionality: This PR removes a substantial amount of code, which might impact existing features or integrations.
  2. Dependency changes: The PR modifies go.mod and go.sum files, potentially affecting the project's dependencies.

Security Hotspots

  1. Removal of attestation logic: The deletion of attestation-related code might impact the security model if it was used for verifying the integrity of transactions or processes.
  2. Removal of QLDB integration: If QLDB was used for maintaining an immutable ledger of transactions, its removal could affect auditability and security of transaction records.
Changes

Changes

  1. .github/workflows/ci.yml:

    • Removed branch ignore for 'nitro-payments-dev'
  2. Dockerfile:

    • Removed the 'payments' stage and its CMD instruction
  3. libs/go.mod and libs/go.sum:

    • Removed dependencies related to AWS QLDB, Nitro enclaves, and vsock
  4. services/go.mod and services/go.sum:

    • Removed dependencies related to AWS services, Nitro enclaves, and experimental packages
  5. Deleted files:

    • Removed multiple files related to Nitro enclave functionality, QLDB integration, and payment processing tools
  6. tools/Dockerfile:

    • Removed the 'payments' stage and its CMD instruction
sequenceDiagram
    participant Developer
    participant GitHubRepo
    participant CI

    Developer->>GitHubRepo: Remove Nitro enclave and payment processing code
    Developer->>GitHubRepo: Update dependencies
    Developer->>GitHubRepo: Remove configuration files
    GitHubRepo->>CI: Trigger CI workflow
    CI->>CI: Run tests and checks
    CI-->>GitHubRepo: Report build status
    GitHubRepo-->>Developer: PR ready for review
Loading

@clD11 clD11 merged commit bfe46a2 into master Dec 17, 2024
13 checks passed
@clD11 clD11 deleted the remove-payment-and-nitro branch December 17, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove payments service from this repo
4 participants