-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove payment and nitro code #2730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Do we still need tools/settlement too? |
@kdenhartog , Yes, until all the custodians and creators are moved over to payments it is still needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[puLL-Merge] - brave-intl/bat-go@2730 DescriptionThis PR removes significant portions of code related to Nitro enclave functionality, including AWS QLDB integration, state machine implementations for different custodians (Bitflyer, Gemini, Uphold), and various payment-related tools and configurations. Possible Issues
Security Hotspots
ChangesChanges
sequenceDiagram
participant Developer
participant GitHubRepo
participant CI
Developer->>GitHubRepo: Remove Nitro enclave and payment processing code
Developer->>GitHubRepo: Update dependencies
Developer->>GitHubRepo: Remove configuration files
GitHubRepo->>CI: Trigger CI workflow
CI->>CI: Run tests and checks
CI-->>GitHubRepo: Report build status
GitHubRepo-->>Developer: PR ready for review
|
Summary
The payments service has been migrated to a separate repository so we no longer need the code in bat-go.
resolves #2708
Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan