New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure that there is room for length header in byte array #18

Closed

IanKrieger wants to merge 1 commit into main from fix/allocate-four-extra-bytes

IanKrieger commented Jan 26, 2024

write_all does not appear to give us the extra bytes we need in order to handle the length header.

Extend the vector instead, and use copy_from_slice as it avoids the overhead of creating an iterator and cloning the bytes.


          fix: ensure that there is room for length header in byte array

77cb49d

IanKrieger requested review from tackley and tsmartt

January 26, 2024 17:33

Author

IanKrieger commented Jan 26, 2024

I think the issue lies in this PR: https://github.com/brave/ads-image-upload/pull/11/files

IanKrieger closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet