Skip to content

Commit

Permalink
Merge pull request #429 from brave/no-panic-generic-procedural-filter
Browse files Browse the repository at this point in the history
Silently ignore generic procedural filter
  • Loading branch information
ShivanKaul authored Feb 12, 2025
2 parents 98aa69f + 2e8a35d commit c9a5b2f
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions src/cosmetic_filter_cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,15 @@ impl CosmeticFilterCache {

/// Add a filter, assuming it has already been determined to be a generic rule
fn add_generic_filter(&mut self, rule: CosmeticFilter) {
let selector = rule
.plain_css_selector()
.expect("Procedural cosmetic filters cannot be generic")
.to_string();
let selector = match rule.plain_css_selector() {
Some(s) => s.to_string(),
None => {
// Procedural cosmetic filters cannot be generic.
// Silently ignoring this filter.
return;
}
};

if selector.starts_with('.') {
if let Some(key) = key_from_selector(&selector) {
assert!(key.starts_with('.'));
Expand Down

1 comment on commit c9a5b2f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: c9a5b2f Previous: 98aa69f Ratio
rule-match-browserlike/brave-list 1793446288 ns/iter (± 21526190) 1717001323 ns/iter (± 16907239) 1.04
rule-match-first-request/brave-list 989830 ns/iter (± 10171) 989900 ns/iter (± 15044) 1.00
blocker_new/brave-list 205510823 ns/iter (± 4795405) 202730589 ns/iter (± 4420888) 1.01
memory-usage/brave-list-initial 41409969 ns/iter (± 3) 41409969 ns/iter (± 3) 1
memory-usage/brave-list-after-1000-requests 44005995 ns/iter (± 3) 44005995 ns/iter (± 3) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.