Code structure follow up #428
Merged
+427
−363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 22dcb7e | Previous: 98aa69f | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
1703637164 ns/iter (± 25099454) |
1717001323 ns/iter (± 16907239) |
0.99 |
rule-match-first-request/brave-list |
1008776 ns/iter (± 8193) |
989900 ns/iter (± 15044) |
1.02 |
blocker_new/brave-list |
202647633 ns/iter (± 2484961) |
202730589 ns/iter (± 4420888) |
1.00 |
memory-usage/brave-list-initial |
41409969 ns/iter (± 3) |
41409969 ns/iter (± 3) |
1 |
memory-usage/brave-list-after-1000-requests |
44005995 ns/iter (± 3) |
44005995 ns/iter (± 3) |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
| // Check for options: option=value1|value2 | ||
| let mut option_and_values = maybe_negated_option.splitn(2, '='); | ||
| let (option, value) = ( | ||
| option_and_values.next().unwrap(), |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] expect or unwrap called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @kdenhartog
atuchin-m
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is easier to review commit by commit:
AbstractNetworkFilterhas been moved to a separate file to reduce the amount of code innetwork.rs.network.rstoregex_manager.rs(also reducing the amount of code). An iterator implementation has been added for theFilterPartenum, and thecompile_regexfunction no longer directly depends onNetworkFilter. String cloning during regex compilation has been removed.HashMapinRegexManagerhas been changed tou64instead of*const NetworkFilter, reducing dependencies onNetworkFilter(a step toward the goal of completely removing this dependency).