Code structure follow up #3. #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 29f787f | Previous: 0fe3582 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
1697628006 ns/iter (± 23321845) |
1839697309 ns/iter (± 11629260) |
0.92 |
rule-match-first-request/brave-list |
1002491 ns/iter (± 20533) |
1015644 ns/iter (± 10433) |
0.99 |
blocker_new/brave-list |
215643394 ns/iter (± 6381520) |
209824147 ns/iter (± 3193249) |
1.03 |
memory-usage/brave-list-initial |
41408849 ns/iter (± 3) |
41409969 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-after-1000-requests |
44004875 ns/iter (± 3) |
44005995 ns/iter (± 3) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
antonok-edm
reviewed
Feb 21, 2025
README.md
Outdated
Comment on lines
57
to
58
| The `unsync-regex-caching` feature enable optimizations for rule matching speed and the amount of memory used by the engine. | ||
| These features can be disabled to make the engine `Send + Sync`, although it is recommended to only access the engine on a single thread to maintain optimal performance. |
There was a problem hiding this comment.
doc here should be updated to refer to the feature singularly (i.e. enable -> enables, These features -> This feature)
src/request.rs
Outdated
| @@ -98,15 +100,25 @@ impl Request { | |||
| if case_sensitive { | |||
| Cow::Borrowed(&self.url) | |||
| } else { | |||
| Cow::Owned(self.url.to_ascii_lowercase()) | |||
| Cow::Borrowed(&self.url_lower_cased) | |||
There was a problem hiding this comment.
can just return &str directly instead of Cow if it's borrowed in all cases
src/request.rs
Outdated
Comment on lines
109
to
111
| ) -> std::iter::Chain< | ||
| core::iter::Flatten<std::option::IntoIter<&Vec<utils::Hash>>>, | ||
| std::slice::Iter<'_, utils::Hash>, |
There was a problem hiding this comment.
return type of impl Iterator<Item=&utils::Hash> would be cleaner here
src/request.rs
Outdated
| pub hostname: String, | ||
| pub request_tokens: Vec<utils::Hash>, |
There was a problem hiding this comment.
let's make these new fields pub(crate), they're an internal implementation detail and we don't want them to be set outside of the constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bench performance has been improved a little.
check,check_allfunctions are simplified.