Review.

brave · Aug 2, 2022 · 340df6f · 340df6f
1 parent d392909
commit 340df6f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/browser/ui/webui/private_new_tab_page/brave_private_new_tab_page_handler.h b/browser/ui/webui/private_new_tab_page/brave_private_new_tab_page_handler.h
@@ -76,7 +76,8 @@ class BravePrivateNewTabPageHandler
 #if BUILDFLAG(ENABLE_TOR)
   raw_ptr<TorLauncherFactory> tor_launcher_factory_ = nullptr;
 #endif
-
+  // Timer for detecting a Tor connection failuer. It starts at each connection
+  // event and shots when the time between events exceeds 15 seconds.
   base::OneShotTimer stuck_timer_;
 
   mojo::Receiver<brave_private_new_tab::mojom::PageHandler> receiver_;

diff --git a/browser/ui/webui/settings/brave_tor_handler.cc b/browser/ui/webui/settings/brave_tor_handler.cc
@@ -21,7 +21,7 @@
 #include "base/strings/utf_string_conversions.h"
 #include "base/task/thread_pool.h"
 #include "base/values.h"
-#include "brave/browser/tor//tor_profile_service_factory.h"
+#include "brave/browser/tor/tor_profile_service_factory.h"
 #include "brave/components/tor/pref_names.h"
 #include "brave/components/tor/tor_profile_service.h"
 #include "brave/components/tor/tor_utils.h"
@@ -90,6 +90,12 @@ constexpr const char16_t kParseBridgesScript[] =
 constexpr int kIsolatedWorldId = content::ISOLATED_WORLD_ID_CONTENT_END + 1;
 }  // namespace
 
+// This class is designed for making request to the Tor bridge web site.
+// It creates WebContents and loads kTorBridgesUrl. When the load complete
+// queries for captcha image and post it to CaptchaCallback.
+// When user resolves captcha BridgeRequest paste it into the loaded WebContents
+// and sumbit a form. Tor bridges site returns list of bridges which parsed and
+// posted to the BridgesCallback.
 class BridgeRequest : public content::WebContentsObserver {
  public:
   using CaptchaCallback = base::OnceCallback<void(const base::Value& image)>;

diff --git a/components/tor/tor_launcher_factory.cc b/components/tor/tor_launcher_factory.cc
@@ -149,9 +149,9 @@ void TorLauncherFactory::GetTorLog(GetLogCallback callback) {
 
 void TorLauncherFactory::SetupPluggableTransport(
     const base::FilePath& snowflake,
-    const base::FilePath& obsf4) {
+    const base::FilePath& obfs4) {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-  control_->SetupPluggableTransport(snowflake, obsf4, base::DoNothing());
+  control_->SetupPluggableTransport(snowflake, obfs4, base::DoNothing());
 }
 
 void TorLauncherFactory::SetupBridges(tor::BridgesConfig bridges_config) {

diff --git a/components/tor/tor_launcher_factory.h b/components/tor/tor_launcher_factory.h
@@ -49,7 +49,7 @@ class TorLauncherFactory : public tor::TorControl::Delegate {
   virtual std::string GetTorVersion() const;
   virtual void GetTorLog(GetLogCallback);
   virtual void SetupPluggableTransport(const base::FilePath& snowflake,
-                                       const base::FilePath& obsf4);
+                                       const base::FilePath& obfs4);
   virtual void SetupBridges(tor::BridgesConfig bridges_config);
 
   void AddObserver(TorLauncherObserver* observer);