Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides stub implementation for RouteObserverMixIn #14522

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Aug 8, 2022

RouteObserverMixin's currentRoutChanged should be overridden. Seems to be regressed from #13290

shared.rollup.js:424 Uncaught Error: Assertion failed: Unreachable code hit
    at assert (shared.rollup.js:424:147)
    at assertNotReached (shared.rollup.js:424:403)
    at SettingsBraveTorPageElement.currentRouteChanged (shared.rollup.js:425:4875)
    at shared.rollup.js:425:1844
    at Set.forEach (<anonymous>)
    at Router.setCurrentRoute (shared.rollup.js:425:1815)
    at Router.navigateTo (shared.rollup.js:425:3177)
    at SettingsMenuElement.onSelectorActivate_ (settings.js:5314:1147)
    at i.<anonymous> (polymer_bundled.min.js:1:23231)
    at i.fire (polymer_bundled.min.js:1:84941)

https://github.com/chromium/chromium/blob/646d3dcc08ed74d1b9522f15270251318bab15ae/chrome/browser/resources/settings/router.js#L434

Resolves brave/brave-browser#24510

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@sangwoo108 sangwoo108 marked this pull request as ready for review August 8, 2022 09:54
RouteObserverMixin's currentRoutChanged should be overridden.
@sangwoo108 sangwoo108 merged commit 4689ab8 into master Aug 8, 2022
@sangwoo108 sangwoo108 deleted the sko/settings branch August 8, 2022 12:09
@sangwoo108
Copy link
Contributor Author

@boocmp Thanks for the review! :)

@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 8, 2022
@boocmp
Copy link
Contributor

boocmp commented Aug 8, 2022

@boocmp Thanks for the review! :)

@sangwoo108 I was sure I added this override, but it seems I accidentally deleted it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password List Will Not Display
2 participants