Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty body case #16364

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Fix empty body case #16364

merged 1 commit into from
Dec 14, 2022

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Dec 14, 2022

Resolves brave/brave-browser#27362

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

if (api_request_result.value_body().is_none() ||
!base::JSONWriter::Write(api_request_result.value_body(), &safe_json)) {
success = false;
// Body might be empty here which is still a success.
Copy link
Contributor

@spylogsster spylogsster Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supermassive do you mind to add a test for this case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually reverted that block to original state. Not sure how to add proper tests here quickly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np, I will add later

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it was broke and that this commit specifically fixes it 🙂👍

I definitely welcome a unit test to enforce this - but I'm OK merging without that

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: ef0e6d5
reason: unsigned
Please follow the handbook to configure commit signing
cc: @supermassive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not receiving Brave VPN credentials with recent nightly
3 participants