Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable v2 ext on toggle turning off. Added the Remove button for disabled extensions. #26903

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Dec 6, 2024

Resolves brave/brave-browser#42608

Video
ext_v2.mp4

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open brave://settings/extensions/v2
  2. Toggle on an extension (it will be installed)
  3. Toggle off the extension, check Remove button appears and extension is disabled (on brave://extension)
  4. Click Remove, check Remove button disappears and extension is uninstalled (on brave://extension)

@boocmp boocmp requested a review from ShivanKaul December 6, 2024 12:45
@boocmp boocmp self-assigned this Dec 6, 2024
@boocmp boocmp requested a review from a team as a code owner December 6, 2024 12:45
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 6, 2024
@ShivanKaul
Copy link
Collaborator

@boocmp can you add some screenshots?

@boocmp
Copy link
Contributor Author

boocmp commented Dec 6, 2024

@boocmp can you add some screenshots?

Yes, recording a video right now

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@bsclifton
Copy link
Member

bsclifton commented Dec 11, 2024

@boocmp can you add a test plan to brave/brave-browser#42608 please? 😄 (or here in the original post)

@boocmp boocmp merged commit c9a9edd into master Dec 12, 2024
20 of 21 checks passed
@boocmp boocmp deleted the ext_v2_ui branch December 12, 2024 12:10
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 12, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning user when disabling MV2 uBlock Origin
6 participants