Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Fix race condition for private browsing only mode #26931

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Dec 9, 2024

Summary

  • Fix a race condition where opening URLs when Brave is NOT in the background, opens with isPrivate: false and does not consider PBO.

Resolves brave/brave-browser#42717

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Make Brave your default browser
  2. Enable Private Browsing Only mode
  3. Open Google Maps
  4. Find a restaurant or park with a website
  5. Tap on it
  6. Tap on "Website" button
  7. Brave opens
  8. URL should be opened in PBO.

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Dec 9, 2024
@Brandon-T Brandon-T self-assigned this Dec 9, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner December 9, 2024 15:27
@Brandon-T Brandon-T merged commit d7aa923 into master Dec 12, 2024
19 checks passed
@Brandon-T Brandon-T deleted the bugfix/SceneDelegatePrivateOnlyMode branch December 12, 2024 15:59
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 12, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links from external sources open in Brave normal browsing even though “Private browsing only” is enabled
3 participants