Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): Allow Creating Wallet on Buy Screen (uplift to 1.74.x) #26935

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(wallet): Allow Creating Wallet on Buy Screen (uplift to 1.74.x) #26935

merged 1 commit into from
Dec 10, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 9, 2024 •
edited by kjozwiak
Loading

Uplift of #26850
Resolves brave/brave-browser#42687

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner December 9, 2024 18:59
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Dec 9, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel added this to the 1.74.x - Beta milestone Dec 9, 2024
kjozwiak
kjozwiak approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.74.x approved 👍 QA has verified the PR on Nightly as per #26850 (comment). As mentioned above, we'll fix the issue that @sri mentioned via #26954 which will be uplifted into 1.74.x as well.

@kjozwiak kjozwiak merged commit 9821ee3 into 1.74.x Dec 10, 2024
17 checks passed
@kjozwiak kjozwiak deleted the pr26850_fix-wallet-allow-creating-account-on-buy-screen_1.74.x branch December 10, 2024 16:23
@brave-builds
Copy link
Collaborator Author

Released in v1.74.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.74.x - Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @Douglashdaniel