Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Backup Wallet Progress Indicator #26956

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes the Backup Wallet Progress Step indicator size and current step.

Resolves brave/brave-browser#42790

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Create a new Wallet and then click the Backup Now button
  2. Once you copy your seed phrase and get to the input verification, you should see the 3 Indicator Steps at the top right.
  3. The Current step should be 24px wide and all others 12px wide
  4. The Current and Completed steps should be filled and the others should not.

Before:

image image image

After:

image image image

@Douglashdaniel Douglashdaniel self-assigned this Dec 10, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner December 10, 2024 17:40
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Dec 10, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit 3093645 into master Dec 12, 2024
19 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-backup-wallet-progress-indicator branch December 12, 2024 16:04
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 12, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading indicator on Wallet seed phrase needs to be as per new design
3 participants