use chromium code for url crate #27880
Merged
+531
−51,074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/run-audit-deps
bridiver
force-pushed
the
stub-url-crate
branch
3 times, most recently
from
bb412fe to
2ebf65a
Compare
iefremov
approved these changes
Mar 3, 2025
antonok-edm
approved these changes
Mar 3, 2025
DJAndries
reviewed
Mar 4, 2025
|
|
||
| impl Error for ParseError {} | ||
|
|
||
| simple_enum_error! { |
There was a problem hiding this comment.
nit: you could use thiserror instead if you want to get rid of the macro
|
Released in v1.78.15 |
DJAndries
reviewed
Mar 4, 2025
| include!("brave/third_party/rust/url/v2/crate/parse.h"); | ||
| fn InitializeICUForTesting(); | ||
| fn ParseURL(url: &str) -> ParseResult; | ||
| fn Resolve(base: &ParseResult, relative: &str) -> ParseResult; |
There was a problem hiding this comment.
Consider returning UniquePtr<ParseResult> and using the CxxString type for all applicable struct fields to avoid unnecessary copying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#44352