[Dialog]: BREAKING Replace 'size' property with media query #914

AlanBreck · 2024-11-26T03:39:56Z

NOTE: this purpose of this PR is not to bring the Dialog component up to date with the latest in Figma, but rather to provide consumers a way of automatically switching between mobile and normal sizes via screen size.

[Dialog]: add customizable media queries for switching to mobile styles
[Dialog]: change position of action buttons right aligned
[Dialog]: scroll entire dialog instead of just .body

github-actions · 2024-11-26T03:43:00Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://914.pr.nala.bravesoftware.com/
✅ Commit preview: https://914.pr.nala.bravesoftware.com/commit-f3b0634e55ae698f3ba646ecca298c8a0711e7fa/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6848 bytes
+ ./tokens/css/variables-browser.css: 6848 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119512 bytes
+ ./tokens/css/variables.css: 119512 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-11-26 03:41:31.487576148 +0000
+++ ./tokens/css/variables-android.css	2024-11-26 03:40:52.263291032 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Nov 22 2024 01:00:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Nov 26 2024 03:40:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-11-26 03:41:31.791578304 +0000
+++ ./tokens/css/variables-browser.css	2024-11-26 03:40:52.243290885 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Nov 22 2024 01:00:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Nov 26 2024 03:40:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-11-26 03:41:32.083580375 +0000
+++ ./tokens/css/variables-ios.css	2024-11-26 03:40:52.279291150 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Nov 22 2024 01:00:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Nov 26 2024 03:40:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-11-26 03:41:32.459583043 +0000
+++ ./tokens/css/variables-marketing.css	2024-11-26 03:40:52.303291326 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Nov 22 2024 01:00:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Nov 26 2024 03:40:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-11-26 03:41:32.751585112 +0000
+++ ./tokens/css/variables-news.css	2024-11-26 03:40:52.331291532 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Nov 22 2024 01:00:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Nov 26 2024 03:40:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-11-26 03:41:33.087587498 +0000
+++ ./tokens/css/variables-newtab.css	2024-11-26 03:40:52.339291591 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Nov 22 2024 01:00:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Nov 26 2024 03:40:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-11-26 03:41:33.367589482 +0000
+++ ./tokens/css/variables-search.css	2024-11-26 03:40:52.323291474 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Nov 22 2024 01:00:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Nov 26 2024 03:40:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-11-26 03:41:33.499590419 +0000
+++ ./tokens/css/variables-web3.css	2024-11-26 03:40:52.343291621 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Nov 22 2024 01:00:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Nov 26 2024 03:40:52 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-11-26 03:41:33.883593140 +0000
+++ ./tokens/css/variables.css	2024-11-26 03:40:52.087289739 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri Nov 22 2024 01:00:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Nov 26 2024 03:40:52 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

fallaciousreasoning

lgtm with comments

src/components/dialog/dialog.svelte

github-actions · 2024-11-27T01:59:32Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://914.pr.nala.bravesoftware.com/
✅ Commit preview: https://914.pr.nala.bravesoftware.com/commit-bc1af72c11698d414751c5949bbf252aff51cc0f/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6848 bytes
+ ./tokens/css/variables-browser.css: 6848 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119512 bytes
+ ./tokens/css/variables.css: 119512 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-11-27 01:57:57.673824651 +0000
+++ ./tokens/css/variables-android.css	2024-11-27 01:57:20.065663828 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 01:57:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-11-27 01:57:57.861825187 +0000
+++ ./tokens/css/variables-browser.css	2024-11-27 01:57:20.045663779 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 01:57:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-11-27 01:57:58.037825687 +0000
+++ ./tokens/css/variables-ios.css	2024-11-27 01:57:20.081663867 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 01:57:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-11-27 01:57:58.249826291 +0000
+++ ./tokens/css/variables-marketing.css	2024-11-27 01:57:20.105663925 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 01:57:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-11-27 01:57:58.361826609 +0000
+++ ./tokens/css/variables-news.css	2024-11-27 01:57:20.129663984 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 01:57:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-11-27 01:57:58.541827122 +0000
+++ ./tokens/css/variables-newtab.css	2024-11-27 01:57:20.137664004 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 01:57:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-11-27 01:57:58.757827737 +0000
+++ ./tokens/css/variables-search.css	2024-11-27 01:57:20.121663964 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 01:57:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-11-27 01:57:58.937828255 +0000
+++ ./tokens/css/variables-web3.css	2024-11-27 01:57:20.145664024 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 01:57:20 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-11-27 01:57:59.221829058 +0000
+++ ./tokens/css/variables.css	2024-11-27 01:57:19.897663416 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 01:57:19 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

github-actions · 2024-11-27T02:04:47Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://914.pr.nala.bravesoftware.com/
✅ Commit preview: https://914.pr.nala.bravesoftware.com/commit-cedbbffba2c95236fdce471216280f04d2face0b/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6848 bytes
+ ./tokens/css/variables-browser.css: 6848 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119512 bytes
+ ./tokens/css/variables.css: 119512 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-11-27 02:03:10.777866752 +0000
+++ ./tokens/css/variables-android.css	2024-11-27 02:02:31.813622222 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 02:02:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-11-27 02:03:11.005868551 +0000
+++ ./tokens/css/variables-browser.css	2024-11-27 02:02:31.797622102 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 02:02:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-11-27 02:03:11.217870225 +0000
+++ ./tokens/css/variables-ios.css	2024-11-27 02:02:31.829622341 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 02:02:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-11-27 02:03:11.445872025 +0000
+++ ./tokens/css/variables-marketing.css	2024-11-27 02:02:31.853622522 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 02:02:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-11-27 02:03:11.625873444 +0000
+++ ./tokens/css/variables-news.css	2024-11-27 02:02:31.881622731 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 02:02:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-11-27 02:03:11.833875087 +0000
+++ ./tokens/css/variables-newtab.css	2024-11-27 02:02:31.889622791 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 02:02:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-11-27 02:03:12.037876697 +0000
+++ ./tokens/css/variables-search.css	2024-11-27 02:02:31.873622672 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 02:02:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-11-27 02:03:12.257878433 +0000
+++ ./tokens/css/variables-web3.css	2024-11-27 02:02:31.893622822 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 02:02:31 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-11-27 02:03:12.525880545 +0000
+++ ./tokens/css/variables.css	2024-11-27 02:02:31.641620933 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Nov 27 2024 00:24:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 27 2024 02:02:31 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

src/components/dialog/dialog.svelte

Updated since last review.

github-actions · 2024-12-06T01:57:36Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://914.pr.nala.bravesoftware.com/
✅ Commit preview: https://914.pr.nala.bravesoftware.com/commit-6925d5bf46fea426b6330044ecedbea9b88c5f59/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6848 bytes
+ ./tokens/css/variables-browser.css: 6848 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119512 bytes
+ ./tokens/css/variables.css: 119512 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-12-06 01:55:59.569885021 +0000
+++ ./tokens/css/variables-android.css	2024-12-06 01:55:21.146004443 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:55:21 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-12-06 01:55:59.861884129 +0000
+++ ./tokens/css/variables-browser.css	2024-12-06 01:55:21.126004504 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:55:21 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-12-06 01:56:00.165883205 +0000
+++ ./tokens/css/variables-ios.css	2024-12-06 01:55:21.162004394 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:55:21 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-12-06 01:56:00.429882396 +0000
+++ ./tokens/css/variables-marketing.css	2024-12-06 01:55:21.182004333 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:55:21 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-12-06 01:56:00.741881428 +0000
+++ ./tokens/css/variables-news.css	2024-12-06 01:55:21.210004246 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:55:21 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-12-06 01:56:01.037880510 +0000
+++ ./tokens/css/variables-newtab.css	2024-12-06 01:55:21.218004222 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:55:21 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-12-06 01:56:01.361879503 +0000
+++ ./tokens/css/variables-search.css	2024-12-06 01:55:21.202004271 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:55:21 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-12-06 01:56:01.689878487 +0000
+++ ./tokens/css/variables-web3.css	2024-12-06 01:55:21.222004209 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:55:21 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-12-06 01:56:02.189876935 +0000
+++ ./tokens/css/variables.css	2024-12-06 01:55:20.978004960 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:55:20 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

src/components/dialog/dialog.svelte

fallaciousreasoning

lgtm with one comment

github-actions · 2024-12-09T21:57:07Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://914.pr.nala.bravesoftware.com/
✅ Commit preview: https://914.pr.nala.bravesoftware.com/commit-1227f1aff9c484eb1713df64317db70c25657700/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6848 bytes
+ ./tokens/css/variables-browser.css: 6848 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119512 bytes
+ ./tokens/css/variables.css: 119512 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-12-09 21:55:29.626889155 +0000
+++ ./tokens/css/variables-android.css	2024-12-09 21:54:50.190865461 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:54:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-12-09 21:55:29.814889194 +0000
+++ ./tokens/css/variables-browser.css	2024-12-09 21:54:50.170865456 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:54:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-12-09 21:55:30.106889256 +0000
+++ ./tokens/css/variables-ios.css	2024-12-09 21:54:50.206865466 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:54:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-12-09 21:55:30.394889316 +0000
+++ ./tokens/css/variables-marketing.css	2024-12-09 21:54:50.230865473 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:54:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-12-09 21:55:30.706889382 +0000
+++ ./tokens/css/variables-news.css	2024-12-09 21:54:50.258865482 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:54:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-12-09 21:55:31.014889448 +0000
+++ ./tokens/css/variables-newtab.css	2024-12-09 21:54:50.266865483 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:54:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-12-09 21:55:31.322889432 +0000
+++ ./tokens/css/variables-search.css	2024-12-09 21:54:50.250865479 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:54:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-12-09 21:55:31.666889418 +0000
+++ ./tokens/css/variables-web3.css	2024-12-09 21:54:50.274865486 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:54:50 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-12-09 21:55:32.150889396 +0000
+++ ./tokens/css/variables.css	2024-12-09 21:54:50.030865415 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:00 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:54:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

github-actions · 2024-12-09T22:00:15Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://914.pr.nala.bravesoftware.com/
✅ Commit preview: https://914.pr.nala.bravesoftware.com/commit-638bb377629a14c297c3c2049e2645b11474ccf0/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6848 bytes
+ ./tokens/css/variables-browser.css: 6848 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119512 bytes
+ ./tokens/css/variables.css: 119512 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-12-09 21:57:30.365836078 +0000
+++ ./tokens/css/variables-android.css	2024-12-09 21:56:50.409620159 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:56:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-12-09 21:57:30.621837447 +0000
+++ ./tokens/css/variables-browser.css	2024-12-09 21:56:50.385620033 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:56:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-12-09 21:57:30.861838732 +0000
+++ ./tokens/css/variables-ios.css	2024-12-09 21:56:50.425620242 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:56:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-12-09 21:57:31.121840123 +0000
+++ ./tokens/css/variables-marketing.css	2024-12-09 21:56:50.445620347 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:56:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-12-09 21:57:31.353841365 +0000
+++ ./tokens/css/variables-news.css	2024-12-09 21:56:50.473620493 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:56:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-12-09 21:57:31.585842606 +0000
+++ ./tokens/css/variables-newtab.css	2024-12-09 21:56:50.481620535 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:56:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-12-09 21:57:31.793843689 +0000
+++ ./tokens/css/variables-search.css	2024-12-09 21:56:50.465620451 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:56:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-12-09 21:57:32.009844794 +0000
+++ ./tokens/css/variables-web3.css	2024-12-09 21:56:50.489620576 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:01 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:56:50 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-12-09 21:57:32.313846342 +0000
+++ ./tokens/css/variables.css	2024-12-09 21:56:50.241619280 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Mon Dec 09 2024 21:36:00 GMT+0000 (Coordinated Universal Time)
+ * Generated on Mon Dec 09 2024 21:56:50 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

petemill

It's a good direction to go in - let's see how it goes!

AlanBreck requested review from fallaciousreasoning and petemill as code owners November 26, 2024 03:39

AlanBreck changed the title ~~dialog media query~~ [Dialog]: Add customizable media queries for mobile styles Nov 26, 2024

fallaciousreasoning previously approved these changes Nov 26, 2024

View reviewed changes

src/components/dialog/dialog.svelte Outdated Show resolved Hide resolved

src/components/dialog/dialog.svelte Outdated Show resolved Hide resolved

AlanBreck force-pushed the dialog-media-query branch from 95378a5 to bc1af72 Compare November 27, 2024 01:56

AlanBreck requested a review from fallaciousreasoning November 27, 2024 01:56

AlanBreck force-pushed the dialog-media-query branch from bc1af72 to cedbbff Compare November 27, 2024 02:01

petemill reviewed Nov 27, 2024

View reviewed changes

src/components/dialog/dialog.svelte Outdated Show resolved Hide resolved

AlanBreck requested a review from petemill November 27, 2024 18:10

fallaciousreasoning approved these changes Nov 27, 2024

View reviewed changes

AlanBreck force-pushed the dialog-media-query branch from cedbbff to 6925d5b Compare December 6, 2024 01:54

AlanBreck requested a review from fallaciousreasoning December 6, 2024 01:55

fallaciousreasoning reviewed Dec 6, 2024

View reviewed changes

src/components/dialog/dialog.svelte Show resolved Hide resolved

fallaciousreasoning approved these changes Dec 6, 2024

View reviewed changes

AlanBreck changed the title ~~[Dialog]: Add customizable media queries for mobile styles~~ [Dialog]: **BREAKING** Add customizable media queries for mobile styles Dec 9, 2024

AlanBreck changed the title ~~[Dialog]: **BREAKING** Add customizable media queries for mobile styles~~ [Dialog]: **BREAKING** Replace 'size' property with media query Dec 9, 2024

AlanBreck force-pushed the dialog-media-query branch from 6925d5b to 1227f1a Compare December 9, 2024 21:54

AlanBreck added 3 commits December 9, 2024 16:54

[Dialog]: change position of action buttons right aligned

8c02d29

[Dialog]: **BREAKING** replace 'size' property with media query

558281c

[Dialog]: scroll entire dialog instead of just .body

638bb37

AlanBreck force-pushed the dialog-media-query branch from 1227f1a to 638bb37 Compare December 9, 2024 21:54

petemill approved these changes Dec 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dialog]: BREAKING Replace 'size' property with media query #914

[Dialog]: BREAKING Replace 'size' property with media query #914

AlanBreck commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024

fallaciousreasoning left a comment

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Dec 6, 2024

fallaciousreasoning left a comment

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

petemill left a comment

[Dialog]: **BREAKING** Replace 'size' property with media query #914

Are you sure you want to change the base?

[Dialog]: **BREAKING** Replace 'size' property with media query #914

Conversation

AlanBreck commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 26, 2024

fallaciousreasoning left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Dec 6, 2024

fallaciousreasoning left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

petemill left a comment

Choose a reason for hiding this comment

[Dialog]: BREAKING Replace 'size' property with media query #914

[Dialog]: BREAKING Replace 'size' property with media query #914

AlanBreck commented Nov 26, 2024 •

edited

Loading