-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes for key sync #87
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but I'm still confused about the motivation for some of these changes. Why do we need another proxy connection to get the worker's private IP address? Can't the leader just call back to the source addresses it gets requests from?
@@ -8,8 +8,8 @@ import ( | |||
) | |||
|
|||
const ( | |||
maxAttstnBodyLen = 1 << 14 // Upper limit for attestation body length. | |||
boxKeyLen = 32 // NaCl box's private and public key length. | |||
maxAttstnBodyLen = 256 * 1024 // Upper limit for attestation body length. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of extra space. How big is the ppoprf state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
between 100 - 200 kb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm, but I agree also with the comment from ralph.
8b1cc70
to
de2d2eb
Compare
de2d2eb
to
12da224
Compare
[puLL-Merge] - brave/nitriding-daemon@87 DescriptionThis PR introduces significant changes to the nitriding-daemon project, focusing on improving the key synchronization process, enhancing network setup, and refining the overall architecture. The changes aim to make the system more robust, secure, and efficient in handling enclave operations and key management. Possible Issues
Security Hotspots
ChangesChanges
Overall, this PR significantly refactors the key synchronization process, improves network setup, and enhances the interaction between the enclave and the application for key management. |
/enclave/state
to prompt key generation from app, and notify the app of new keys