-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workaround for x86_64-android #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Did you test the android build CI? I think it may apply to the android bindings build also
f41a513
to
f5a2fc4
Compare
I was thinking it might propagate to the sdk-bindings build, because sdk-bindings uses sdk-core. Let's add this into sdk-bindings when someone runs into the same error there. |
@ademar111190 Could you help us with this by running the Android example app you've created recently on a x86_64 emulator? |
@erdemyerebasmaz yeap the error is happening; I'll try later the fix.
|
I tried a build for sdk-flutter where flutter uses sdk-bindings instead of sdk-core on an x86_64 emulator, and it worked. So the sdk-core change also propagates to sdk-bindings. |
As discussed with @erdemyerebasmaz, these changes should be put in |
678acd4
to
eb4a787
Compare
eb4a787
to
1d71de6
Compare
A workaround that fixes breez/c-breez#553
Recommended by @yukibtc here breez/c-breez#553 (comment)
Flutter uses sdk-core for Android, that's why this build script is put in sdk-core. It may be necessary to put it in sdk-bindings as well, for bindings for other languages that work on android, not sure.
Did a testrun with a breez-sdk-flutter release from the CI: https://github.com/breez/breez-sdk/suites/16489120334/artifacts/942132999
The testrun worked.