Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Flutter 3.16 breaking changes #719

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Address Flutter 3.16 breaking changes #719

merged 7 commits into from
Nov 16, 2023

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Nov 16, 2023

This PR addresses breaking changes and deprecations introduced on Flutter 3.16.

Changelist:

As of this release, the default theme for Material Flutter apps is Material 3. Unless you explicitly specify Material 2 (with useMaterial3: false) in your app’s theme, your app will look different once you’ve updated.

The Impeller runtime is now available for Android on Vulkan devices behind the --enable-impeller flag.

  • Enable Flutter's new rendering engine, Impeller, on Android devices that support Vulkan e488ca5

Deprecated just-in-time navigation pop APIs for Android Predictive Back

  • Deprecate just-in-time navigation pop APIs for Android Predictive Back c464e4a
    • Requires additional testing

Deprecate textScaleFactor in favor of TextScaler

  • Deprecate textScaleFactor in favor of TextScaler 4f185f0
    • Requires additional testing
  • Non-related SDK requirement: Add mandatory network field to placeholder LNInvoice e605835
    • Cherry-picked to main
  • Temporary fix for mergeDebugNativeLibs errors 518d3aa
  • Update dependencies to latest

@erdemyerebasmaz
Copy link
Collaborator Author

erdemyerebasmaz commented Nov 16, 2023

Findings:
"Deprecate just-in-time navigation pop APIs for Android Predictive Back" changes aren't working as expected when there's no NavigatorState available on context using native back button on Android.

⚠️ Do not merge until this is addressed. ⚠️

"Deprecate textScaleFactor in favor of TextScaler" changes has caused a slight difference in text size that are in acceptable levels, which is only noticeable on the large text scale factors.

Large text scale factor Small text scale factor
Screen.Recording.2023-11-16.at.18.36.32.mov
Screen.Recording.2023-11-16.at.18.39.39.mov

Difference in underline color of text field is noted will be investigated, could be a focused/unfocused state difference.

Tests completed for:
- [x] HomePage
- [x] BreezAvatarDialog
- [x] PaymentOptionsPage
- [x] promptError (error_dialog.dart)
- [x] LockScreen
- [x] EnterMnemonicsPage
- [x] PaymentRequestDialog
- [x] UserApp
on Android
@erdemyerebasmaz
Copy link
Collaborator Author

Findings: "Deprecate just-in-time navigation pop APIs for Android Predictive Back" changes aren't working as expected when there's no NavigatorState available on context using native back button on Android.

⚠️ Do not merge until this is addressed. ⚠️

Addressed here: Deprecate just-in-time navigation pop APIs for Android Predictive Back

@erdemyerebasmaz erdemyerebasmaz merged commit 978f5aa into main Nov 16, 2023
@erdemyerebasmaz erdemyerebasmaz deleted the flutter-3.16 branch November 16, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant