Notification service for Android #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
reviewed
Dec 8, 2023
roeierez
requested changes
Dec 13, 2023
| override fun onMessageReceived(remoteMessage: RemoteMessage) { | ||
| Log.d(TAG, "From: ${remoteMessage.from}") | ||
|
|
||
| // Check if message contains a data payload. |
There was a problem hiding this comment.
Is this logic in Breez mobile needed to still be able to handle notifications in flutter? https://github.com/breez/breezmobile/blob/master/android/app/src/main/java/com/breez/client/BreezFirebaseMessagingService.java#L48
| return ForegroundInfo( | ||
| NOTIFICATION_ID_PAYMENT_RECEIVED, | ||
| createNotification( | ||
| "Incoming payment", |
There was a problem hiding this comment.
Is this showing during the payment? If so perhaps "Receiving payment..." ?
There was a problem hiding this comment.
Yes, this is the initial message of notification. I was referencing iOS notification, we should change it there as well.
roeierez
requested changes
Dec 14, 2023
erdemyerebasmaz
force-pushed
the
android-notification
branch
2 times, most recently
from
a4e0f56 to
baedeed
Compare
erdemyerebasmaz
force-pushed
the
android-notification
branch
5 times, most recently
from
fcfdcde to
ee0e07e
Compare
- Handle notifications only if app is in the background or killed - Create BreezNotificationService - Create separate notification for each paymentHash - Handle status notification separately - Create JobManager - Rename BreezFCMService to BreezFcmService - Prevent running job for existing payment - Read mnemonics from Keystore - Increase minSdkVersion to 24 - Use shared instance for BreezSdk - Stop job after 1 minute - Declare ndkVersion as flutter.ndkVersion
erdemyerebasmaz
force-pushed
the
android-notification
branch
from
ee0e07e to
fc098b5
Compare
ctd. Remove Flutter implementation for background messages & workmanager
Set hydrated_bloc to fix 9.1.2 version due to a regression on 9.1.3
erdemyerebasmaz
force-pushed
the
android-notification
branch
from
fc098b5 to
0dcbd51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roeierez Created a draft PR to make it easier to review progress.