Use recommended fees when calculating claim tx feerates for send chain swap fee estimates #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n swap fee estimates Integrate recommendedFees & display economy, regular, priority fee options
ok300
approved these changes
Jul 19, 2024
dangeross
reviewed
Jul 19, 2024
| bool isAffordable({int? balanceSat, int? walletBalanceSat, required int amountSat}) { | ||
| assert(balanceSat != null); | ||
|
|
||
| return balanceSat! >= pairInfo.receiverAmountSat.toInt(); |
There was a problem hiding this comment.
Should check receiver_amount_sat + total_fees_sat
There was a problem hiding this comment.
Should check
receiver_amount_sat + total_fees_sat
Good catch!
It now uses the fee calculation on pair info's extension 22ca11f
extension PreparePayOnchainResponseAffordable on PreparePayOnchainResponse {
bool isAffordable({required int balance}) {
return balance >= (receiverAmountSat + totalFeesSat).toInt();
}
}
|
Is it clear in the UI that the fee selection only applies to the Bitcoin claim ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65
Integrate
recommendedFees& display economy, regular, priority fee options.