check historical payments on startup #37
Open
+937
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JssDWt
force-pushed
the
jssdwt-all-payment-results
branch
from
99fcccc to
1c5eed5
Compare
If a payment attempt is started, but the process is killed before the payment is completed, the swap will remain locked for payment. On startup, uncompleted payments are checked. If the payment is no longer inflight, the swap will be unlocked.
If the payment attempt and lock are not added in a transaction, the payment monitor has to contain logic to distinguish when a payment was locked but an attempt was not added. By putting these in a transaction, the payment is always locked when a payment attempt is added, and always unlocked when the payment result is added. Making it easier to determine which payment attempts are stale.
JssDWt
force-pushed
the
jssdwt-all-payment-results
branch
from
1c5eed5 to
57564f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a payment attempt is started, but the process is killed before the
payment is completed, the swap will remain locked for payment. On
startup, uncompleted payments are checked. If the payment is no longer
inflight, the swap will be unlocked.