Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that the PHP 8.0 build fails without the patch for OpenSSL 3.2 #140

Closed

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@GrahamCampbell GrahamCampbell changed the title Use OpenSSL 3.2 across all PHP versions Confirm that the PHP 8.0 build fails without the patch for OpenSSL 3.2 Nov 16, 2023
@mnapoli
Copy link
Member

mnapoli commented Nov 16, 2023

I'd rather not patch PHP 8.0, I don't see a reason to do so?

@GrahamCampbell
Copy link
Contributor Author

This PR was created just temporarily to confirm that the other PR was good. OpenSSL 1.1.1 has known security vulnerabilities, and multiple other OS distributions that ship PHP 8.0 with OpenSSL 3.0 apply this patch - this is where it came from.

@GrahamCampbell GrahamCampbell deleted the openssl-32-no-patch branch November 16, 2023 11:55
@mnapoli
Copy link
Member

mnapoli commented Nov 16, 2023

Right, but PHP 8.0 is not maintained at all in a few days, so I don't think it will be a huge difference.

@GrahamCampbell
Copy link
Contributor Author

I'd still like to make the change to have Bref 2 using the same OpenSSL version across the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants