New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file_exists check to prevent early require fatal #142

Merged

mnapoli merged 1 commit into brefphp:main from KorvinSzanto:error-without-vendor

Nov 24, 2023

Contributor

KorvinSzanto commented Nov 23, 2023

This PR is in relation to brefphp/constructs#12

By checking for the file to exist before requireing it we allow the later thrown exception to flow out as intended.


          Add file_exists check to prevent require fatal.

f9dd2fc

mnapoli approved these changes

View reviewed changes

Member

mnapoli left a comment

Oh interesting, I was thinking about adding a new exception but the existing exception makes sense too! That's a good idea!

I've approved the pipeline so tests run, will merge later (this will take a while).

mykiwi approved these changes

View reviewed changes

mnapoli merged commit 103cb8f into brefphp:main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet