-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a layer for the opentelemetry php extension #501
Conversation
iokiwi
commented
Nov 19, 2023
- https://github.com/open-telemetry/opentelemetry-php-instrumentation
- https://opentelemetry.io/docs/instrumentation/php/automatic/
How large is the generated layer, btw? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still keep the make flags, but this is fast to build in any case, so it won't make a lot of difference (if implemented correctly for grpc, it actually does make a big difference there).
This reverts commit 7258cc9.
Aight restored. Yeah I should have checked what they do. Probably wont make a big practical differences as opentelemetry is quick but might as well have them. Thanks! |
Hey sorry I added the extension to the readme as well. I don't have merge rights so I'm not sure what the next steps after reviewer approval are. |