Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the "support_tags" command when running with no hooks… #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lambdaknight
Copy link

… or in "no daemon" mode.

I added a issue (#139) about "support_tags" not working in "no daemon" mode. I made a small change that gets it working. Not sure it is the optimal way to do it, but I leave it here for your perusal.

@calvn
Copy link
Contributor

calvn commented Feb 22, 2017

Awesome! Can you add some tests for these changes?

@lambdaknight
Copy link
Author

I added a test. Sorry this took so long. I don't have much time to work on this. As a disclaimer, I want to say that I don't program in JS much, so apologies if this code is just absolutely terrible.

@breser
Copy link
Owner

breser commented Aug 12, 2017

Can you rebase this so that it picks up the fixes to the broken test suite?

@khdevel
Copy link

khdevel commented Aug 24, 2017

Could you please give some information when this fix will be merged to the master branch? Thank you @breser

@breser
Copy link
Owner

breser commented Aug 24, 2017

@khdevel Was hoping @lambdaknight would rebase this so that I could see that the tests properly pass since the test suite was broken when he did this. Hasn't happened yet so I need to find some time to do it myself.

@khdevel
Copy link

khdevel commented Aug 25, 2017

Great @breser ! I extremely need such change for my super-mega deployment process :) I am looking forward for it!

@khdevel
Copy link

khdevel commented Nov 7, 2017

...any news about the release day?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants